Use an explicit skip list for columns ignored during auto-grouping - #1053
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 203 203
Lines 13789 13789
Branches 1688 1688
=======================================
Hits 11974 11974
Misses 1266 1266
Partials 549 549 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Instead of deriving the ignored set from the complement of SCALED_AESTHETICS, list the non-aesthetic/special columns directlyl. This allows custom geoms and stats to define aesthetics that affect the grouping.
has2k1
force-pushed
the
grouping-columns
branch
from
April 18, 2026 07:48
3a17025 to
be6baf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of deriving the ignored set from the complement of SCALED_AESTHETICS, list the non-aesthetic/special columns directlyl. This allows custom geoms and stats to define aesthetics that affect the grouping.